Update to style-components v4 #1

Activity

1. diegomura commented on Feb 18, 2019

   

   diegomura

   on Feb 18, 2019

   Contributor

   More actions

   Thanks! I'm not that familiar with v4 changes. Could you explain a bit further why you think is that?
2. gabimoncha commented on Feb 18, 2019

   

   gabimoncha

   on Feb 18, 2019

   Author

   More actions

   From what I understand v4 is smaller, but also mounts faster due to some refactoring and optimisations around memory usage and JS engine implementation details.
3. diegomura commented on Feb 18, 2019

   

   diegomura

   on Feb 18, 2019

   Contributor

   More actions

   Ok. Sounds good!
   I'll try to take a look at this soon, but I still have some other issues to tackle before this 😅 .
   Feel free to jump on this if you like!
4. gabimoncha commented on Feb 19, 2019

   

   gabimoncha

   on Feb 19, 2019

   Last edited by gabimoncha

   Author

   More actions

   One nice issue that I can't do, is the support of SVGs for react-pdf :)
5. diegomura commented on Feb 22, 2019

   

   diegomura

   on Feb 22, 2019

   Contributor

   More actions

   I just checked this, and it wouldn't be that simple to implement. The main cause is that styled-components v4 does not export the lib dir but just the bundles. I'm not going to work on this in the near future, so if someone feels like tackling this, please do!