Skip to content

event.which is deprecated which causes issues when using @testling-library/user-event v14 #977

Open
Open
event.which is deprecated which causes issues when using @testling-library/user-event v14#977

Description

@kapiljaveri
kapiljaveri
opened on Aug 30, 2023

https://developer.mozilla.org/en-US/docs/Web/API/UIEvent/which

Issue found here - testing-library/user-event#1137

It's recommended to switch over to event.code or event.key instead - testing-library/user-event#842 (comment)

Activity

  1. kapiljaveri commented on Aug 30, 2023

    @kapiljaveri
    kapiljaveri
    on Aug 30, 2023
    Author

    Probably looks like we also need to change - https://github.com/react-component/util/blob/master/src/KeyCode.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions