Repository navigation
Allow user to add custom header classes - #66
Merged
Merged
Conversation
|
Changes Unknown when pulling 01d8138 on Brookelyn:master into ** on react-component:master**. |
Contributor
|
1.7.2 published. Thanks for you pr. |
Member
|
@shepherdwind classname is added a suffix space，cause antd-mobile snapshot test broken... |
paranoidjk
referenced
this pull request
in ant-design/ant-design-mobile
Apr 26, 2017
4 tasks done
paranoidjk
added a commit
to ant-design/ant-design-mobile
that referenced
this pull request
Apr 26, 2017
benjycui
reviewed
Apr 26, 2017
| destroyInactivePanel, | ||
| } = this.props; | ||
| const headerCls = `${prefixCls}-header`; | ||
| const headerCls = `${prefixCls}-header ${headerClass}`; |
Member
There was a problem hiding this comment.
We should use classNames here.
benjycui
added a commit
that referenced
this pull request
Apr 26, 2017
shepherdwind
added a commit
that referenced
this pull request
Apr 26, 2017
fix: remove useless space, ref: #66
lixiaoyang1992
pushed a commit
to lixiaoyang1992/ant-design-mobile
that referenced
this pull request
Apr 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to add custom styles to the header where I'm using this component, and realised that others may be likely to want to do the same. Therefore, I've added in a new prop, headerClass, to allow users to add customer header styles to this area of the component.
Thanks for creating an awesome component, and please let me know if I've missed anything out! :)