Repository navigation
Fix deprecation warnings for react >= 15.5.0 - #58
Merged
shepherdwind merged 3 commits intoApr 11, 2017
Merged
Conversation
y-yagi
changed the title
afc163
reviewed
Apr 10, 2017
| @@ -1,4 +1,5 @@ | |||
| import React, { PropTypes, Children }from 'react'; | |||
| import React, { Children }from 'react'; | |||
Member
There was a problem hiding this comment.
- import React, { Children }from 'react';
+ import React, { Children } from 'react';
Member
|
Rebase master |
y-yagi
force-pushed
the
migrate_to_react_v15.5.0
branch
from
April 10, 2017 03:11
f28ca8c to
af485ce
Compare
y-yagi
force-pushed
the
migrate_to_react_v15.5.0
branch
from
April 10, 2017 03:14
af485ce to
75a3523
Compare
Contributor
Author
|
Rebased with master. |
| } | ||
|
|
||
| const Collapse = React.createClass({ | ||
| const createReactClass = require('create-react-class'); |
Contributor
There was a problem hiding this comment.
Very thanks for you contribution.
But, I think It is better to change the createReactClass code to class style component.
Contributor
Author
There was a problem hiding this comment.
Thank you for your comment.
I changed the createReactClass code to class style component.
Please review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
In React v15.5.0,
React.PropTypesandReact.createClassbecame deprecate.So I migrated to
prop-typespackage andcreate-react-classpackage.