Skip to content

Remove PanelContent from DOM if it's Panel inactive - #44

Merged
shepherdwind merged 1 commit into
react-component:masterfrom
stavenko:master
Apr 18, 2017
Merged

shepherdwind merged 1 commit into
react-component:masterfrom
stavenko:master

Conversation

@stavenko

Copy link
Copy Markdown

Make rendering of div element, containeing children dependent on Panel isActive flag.
Fixing #43 issue.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 96.032% when pulling d57f083 on stavenko:master into 312f1fb on react-component:master.

@benjycui

Copy link
Copy Markdown
Member

A configuration will be better, for we don't know whether user's code has side effects or not.

see destroyInactiveTabPane in https://github.com/react-component/tabs#tabs

@shepherdwind
shepherdwind merged commit e99c100 into react-component:master Apr 18, 2017
@shepherdwind

Copy link
Copy Markdown
Contributor

#61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants