Allow to set 'id' attribute to the panel #69

Activity

1. benjycui commented on May 12, 2017

   

   benjycui

   on May 12, 2017

   Member

   More actions

   Nope, just use:

   <Panel>
     <div id="..."></div>
   </Panel>
2. benjycui commented on May 12, 2017

   

   benjycui

   on May 12, 2017

   Member

   More actions

   @shepherdwind I am not sure if we can pass rest props to panel?

   collapse/src/Panel.jsx

   Lines 14 to 22 in f6ea09b

   	className,
   	style,
   	prefixCls,
   	header,
   	headerClass,
   	children,
   	isActive,
   	showArrow,
   	destroyInactivePanel,

   👍React with 👍1Reacted by Eward
3. mikhailChibel commented on May 12, 2017

   

   mikhailChibel

   on May 12, 2017

   Last edited by mikhailChibel

   Author

   More actions

   @benjycui sure I can set id on the content of the panel. I would be nice to have an id of the panel itself, as it can simplify, for example, UI tests.
4. paranoidjk commented on May 12, 2017

   

   paranoidjk

   on May 12, 2017

   Member

   More actions

   nope. There should never be a id api，but we may consider pass down rest props
5. shepherdwind commented on May 12, 2017

   

   shepherdwind

   on May 12, 2017

   Contributor

   More actions

   Rest props pass to panel is ok. But, I think that React will throw error when pass an unknown prop to panel.
6. paranoidjk commented on May 12, 2017

   

   paranoidjk

   on May 12, 2017

   Member

   More actions

   Rest props pass to panel is ok. But, I think that React will throw error when pass an unknown prop to panel.

   IMO, This is not our concern, we just need to make sure all api which shown in doc are handled, then rest props should be all html valiad.
7. mikhailChibel commented on Jun 6, 2017

   

   mikhailChibel

   on Jun 6, 2017

   Author

   More actions

   @benjycui Any hope on resolving this issue anytime soon?
8. benjycui commented on Jun 6, 2017

   

   benjycui

   on Jun 6, 2017

   Member

   More actions

   ping @shepherdwind
9. shepherdwind

   added a commit that references this issue on Jun 6, 2017

   feat: add prop id for Panel

   ...

   This issue will close once commit 5f98306 is merged into the 'master' branch.

   5f98306
10. shepherdwind commented on Jun 6, 2017

    

    shepherdwind

    on Jun 6, 2017

    Contributor

    More actions

    Pass rest props to panel div will give it too much useless prop.

    So, The only way is to add a prop id , see mr #72
11. shepherdwind

    closed this as completedin #72on Jun 19, 2017
12. shepherdwind commented on Jun 19, 2017

    

    shepherdwind

    on Jun 19, 2017

    Contributor

    More actions

    1.7.6