Repository navigation
Add DataFrame.fromArrow - #250
Merged
Merged
Conversation
matekdev
approved these changes
Jun 28, 2021
bryevdv
marked this pull request as ready for review
June 28, 2021 18:12
Contributor
|
Reviewed in the morning and didn't realize I accidently approved. Will give it another look over. |
Contributor
|
|
Contributor
Author
|
Good catch, updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a static
DataFrame.fromArrowmethod that can adapt Arrow tables stored in-memory in Arrow IPC format.This is still WIP but early comments welcome. Some notes:
cudf::from_arrowto allow it to perform zero-copy when feasible (e.g. ipc buffers)Still need to add an input type tofromArrow(similar toreadCSV) so that full types can be deduced