Repository navigation
End the bootstrap mode once the standing dialog is initialized - #228
Open
mt-software-de wants to merge 1 commit into
Open
mt-software-de wants to merge 1 commit into
mt-software-de wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FinTS3PinTanClient._bootstrap_modeis set in the constructor and only reset at the end ofget_tan_media(). A client that never callsget_tan_media()stays in bootstrap mode forever, e.g. because the TAN method needs no medium, or because it is restored withfrom_datafor a later session. In bootstrap mode a9075 Starke Authentifizierung erforderlich.is ignored:get_transactions()returns an empty list instead of raisingFinTSSCARequiredError, so an application cannot tell "no transactions" from "the bank asks for a strong customer authentication". This happens with Consorsbank for HKKAZ 7 (9050 Nachricht teilweise fehlerhaft./9075 Starke Authentifizierung erforderlich.).The bootstrap mode now ends when the standing dialog is initialized (
with client:), the bootstrap itself (fetch_tan_mechanisms(),get_tan_media()) runs without a standing dialog.Related to #214, which resets the bootstrap mode at the end of
fetch_tan_mechanisms(). That doesn't cover clients restored withfrom_data, which usually don't callfetch_tan_mechanisms()again.Note that out of bootstrap mode the existing PIN safety check applies too: a 9xxx response before the dialog is open blocks the PIN, as intended.
The test server gets a login
test-scathat responds to HKKAZ with 9050/9075, and a test checks thatFinTSSCARequiredErroris raised.