Repository navigation
Fix the constant coefficient sign in Plane3.contains - #280
Open
xixihaha-ha wants to merge 1 commit into
Open
xixihaha-ha wants to merge 1 commit into
xixihaha-ha wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plane3.containssubtracts the constant coefficient, although planes and their constructors usen @ p + d = 0. For example,Plane3([1, 0, 0, -2]).contains([2, 0, 0])returns false, while the point[-2, 0, 0]is incorrectly accepted.Use the same sign as the plane equation. Regression tests cover translated planes constructed from coefficients, point/normal and three points, positive/negative coefficient scaling, off-plane points, tolerance, and the origin-plane case.
Validation: 10 failures before the one-line fix; all 11 new cases pass afterward. Full suite: 484 passed, 3 skipped, 63 subtests passed (Windows, Python 3.12, Matplotlib Agg). Black check for the new test file passes.
Prepared with AI assistance; reproductions and tests were executed locally.