Repository navigation
Make the LGTM starter work in tests and warn about missing Dev Services properties - #57375
Open
omatheusmesmo wants to merge 1 commit into
Open
omatheusmesmo wants to merge 1 commit into
omatheusmesmo wants to merge 1 commit into
Conversation
…es properties The generated SimpleTest injects grafana.endpoint and otel-collector.url, which are only set when the LGTM Dev Service runs. Since Dev Services are disabled in test mode by default, a fresh LGTM starter failed to boot its own test. The codestart now sets quarkus.observability.enabled-in-tests=true. Applications that require a property provided by the observability Dev Services in test mode, without defining it, now get a warning naming the property and quarkus.observability.enabled-in-tests. Nothing is logged for applications that do not need them. * Fix quarkusio#56950 Signed-off-by: Matheus Oliveira <matheus.6148@gmail.com>
quarkus-bot
Bot
added
the
area/devtools
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Changes
Since #54952, observability Dev Services are not started in test mode unless
quarkus.observability.enabled-in-tests=trueis set. The LGTM codestart still generates aSimpleTestthat injectsgrafana.endpointandotel-collector.url, which only the Dev Service provides, so a fresh starter failed to boot its own test.The codestart now sets the property. For existing apps in the same situation, a warning naming the missing properties and the config to enable them is logged only when a required
@ConfigPropertymatches a property the Dev Services would provide, so apps that don't need LGTM see nothing.