Skip to content

docs: TestContainers integration - #710

Merged
anush008 merged 10 commits into
masterfrom
testcontainers
Mar 20, 2024
Merged

anush008 merged 10 commits into
masterfrom
testcontainers

Conversation

@anush008

@anush008 anush008 commented Mar 13, 2024 •

Copy link
Copy Markdown
Member

EDIT: Releasing this page. Commented out the unreleased Node and Python modules. Will add them back later.

Preview

Additionally, this PR adds some more info to the Spring AI integration docs.

Waiting on

@anush008
anush008 requested a review from mjang March 13, 2024 07:48
@netlify

netlify Bot commented Mar 13, 2024 •

Copy link
Copy Markdown

✅ Deploy Preview for condescending-goldwasser-91acf0 ready!

Name Link
🔨 Latest commit cec1042
🔍 Latest deploy log https://app.netlify.com/sites/condescending-goldwasser-91acf0/deploys/65fa69ca0d4532000793287d
😎 Deploy Preview https://deploy-preview-710--condescending-goldwasser-91acf0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mjang

mjang commented Mar 13, 2024

Copy link
Copy Markdown
Contributor

@anush008 , I see several extra files in this PR, some related to Spring AI. I'll review the testcontainers.md file.

Comment thread qdrant-landing/content/documentation/frameworks/testcontainers.md Outdated
Comment thread qdrant-landing/content/documentation/frameworks/testcontainers.md Outdated
@anush008

anush008 commented Mar 13, 2024 •

Copy link
Copy Markdown
Member Author

@anush008 , I see several extra files in this PR, some related to Spring AI. I'll review the testcontainers.md file.

Yes. I wanted to add some more info to the Spring AI docs. Though it would be quicker to add here.

Also, we didn't have an icon for Go lang snippets that the TestContainers code example needs. So I added it.

The CSS was rebuilt after adding the icon/SCSS and running https://github.com/qdrant/landing_page?tab=readme-ov-file#build-css-from-scss.

@eddumelendez eddumelendez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project's name is Testcontainers :)

Comment thread qdrant-landing/content/documentation/frameworks/testcontainers.md Outdated
Comment thread qdrant-landing/content/documentation/frameworks/testcontainers.md Outdated
Comment thread qdrant-landing/content/documentation/frameworks/testcontainers.md Outdated
Comment thread qdrant-landing/content/documentation/frameworks/testcontainers.md Outdated
Comment thread qdrant-landing/content/documentation/frameworks/testcontainers.md Outdated
Comment thread qdrant-landing/content/documentation/frameworks/testcontainers.md Outdated
Co-authored-by: Eddú Meléndez Gonzales <eddu.melendez@gmail.com>

@mjang mjang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a couple of requested changes. @anush008, I trust you. I've now also reviewed the new Spring AI content.

Comment thread qdrant-landing/content/documentation/frameworks/testcontainers.md Outdated
Comment thread qdrant-landing/content/documentation/frameworks/spring-ai.md Outdated
Comment thread qdrant-landing/content/documentation/frameworks/testcontainers.md Outdated
Comment thread qdrant-landing/content/documentation/frameworks/testcontainers.md Outdated
anush008 and others added 3 commits March 14, 2024 18:30
Co-authored-by: Mike Jang <michael.jang@qdrant.io>
Co-authored-by: Mike Jang <michael.jang@qdrant.io>
@anush008

Copy link
Copy Markdown
Member Author

Waiting on

@anush008 anush008 added the do not merge For release on a specified date label Mar 14, 2024
Comment thread qdrant-landing/content/documentation/frameworks/testcontainers.md Outdated
@mjang mjang mentioned this pull request Mar 15, 2024
@anush008 anush008 removed the do not merge For release on a specified date label Mar 20, 2024
@anush008
anush008 merged commit a21aa0c into master Mar 20, 2024
@anush008
anush008 deleted the testcontainers branch March 20, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants