Repository navigation
Minor tweaks to PEP 544 - #1046
Merged
Merged
Conversation
gvanrossum
reviewed
May 12, 2019
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
Where’s the text about classes inheriting from protocols?
| ... | ||
| else: | ||
| # type of x is "int" here? | ||
| # Statically type of x is int statically, |
Member
Author
Do you mean normal classes inheriting from protocols or protocols inheriting from other protocols? These are in different sections. One is |
gvanrossum
approved these changes
May 12, 2019
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
I was referring to class objects as mentioned in the PR description. But now I see it’s okay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @gvanrossum @JukkaL @ambv
This PR contains mostly minor wording tweaks plus a paragraph explicitly allowing class objects as implementations of protocols, previously there were questions whether it is actually allowed, see python/mypy#4536.