Skip to content

gh-146102: Avoid possibe memory leak in pylifecycle.c - #151534

Open
IvyXu420 wants to merge 2 commits into
python:mainfrom
IvyXu420:fix-146102
Open

gh-146102: Avoid possibe memory leak in pylifecycle.c#151534
IvyXu420 wants to merge 2 commits into
python:mainfrom
IvyXu420:fix-146102

Conversation

@IvyXu420

@IvyXu420 IvyXu420 commented Jun 16, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot mentioned this pull request Jun 16, 2026
Open
@Wulian233

Wulian233 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

I have already made a similar PR before. However, if yours is better, I will close mine
#149631

@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Sep 17, 2026
BHUVANSH855
BHUVANSH855 reviewed Oct 22, 2026
View reviewed changes

@BHUVANSH855 BHUVANSH855 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you have a look on these points.

Comment thread Python/pylifecycle.c

@BHUVANSH855 BHUVANSH855 Oct 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pycore_init_builtins still leaks bimod on the _PyBuiltin_InitPythonFunctions early return (inside config->_install_importlib). Also the two fixed sites should be Py_DECREF not Py_XDECREF, bimod is non-NULL there.

new_interpreter: _PyObject_InitState and _PyStats_InterpInit failure checks still return status instead of goto error, skipping _PyThreadState_Attach.

Comment thread Misc/NEWS.d/next/Core_and_Builtins/2026-06-16-16-19-42.gh-issue-146102.xtcD4F.rst

@BHUVANSH855 BHUVANSH855 Oct 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests were added. I think Lib/test/test_interpreters/test_lifecycle.py would be right place.

NEWS entry should reference gh-149630, not gh-146102 (that's the umbrella).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner
1 more reviewer
@BHUVANSH855 BHUVANSH855 BHUVANSH855 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IvyXu420 @Wulian233 @BHUVANSH855