Repository navigation
IOCP Proactor same socket overlapped callbacks #85418
Description
| BPO | 41246 |
|---|---|
| Nosy | @JimJJewett, @tontinton |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2020-07-08.17:20:08.338>
labels = ['3.10']
title = 'IOCP Proactor same socket overlapped callbacks'
updated_at = <Date 2020-08-30.05:01:41.656>
user = 'https://github.com/tontinton'bugs.python.org fields:
activity = <Date 2020-08-30.05:01:41.656>
actor = 'Jim.Jewett'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2020-07-08.17:20:08.338>
creator = 'tontinton'
dependencies = []
files = []
hgrepos = []
issue_num = 41246
keywords = ['patch']
message_count = 4.0
messages = ['373324', '373533', '373534', '376081']
nosy_count = 2.0
nosy_names = ['Jim.Jewett', 'tontinton']
pr_nums = ['21399']
priority = 'normal'
resolution = None
stage = 'commit review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue41246'
versions = ['Python 3.10']
Activity
tontinton commentedon Jul 8, 2020
In IocpProactor I saw that the callbacks to the functions recv, recv_into, recvfrom, sendto, send and sendfile all give the same callback function for when the overlapped operation is done.
I just wanted cleaner code so I made a static function inside the class that I give to each of these functions as the overlapped callbacks.
jimjjewett commentedon Jul 11, 2020
Looks good to me.
I at first worried that the different function names were useful metadata that was getting lost -- but the names were already duplicated in several cases. *If* that is still a concern for the committer, then instead of repeating the code (as current production does), each section should just say newname=origname before registering the static method (as the patch does), and should bind a distinct name for each usage.
tontinton commentedon Jul 11, 2020
I feel like the metadata is not really a concern here. I like when there is no code duplication :)
tontinton commentedon Aug 29, 2020
bump