del ssl.SSLContext().keylog_filename crashes #156099
Copy link
Copy link
Closed
Labels
3.13only security fixesonly security fixes3.14bugs and security fixesbugs and security fixes3.15bugs and security fixesbugs and security fixes3.16new features, bugs and security fixesnew features, bugs and security fixesextension-modulesC modules in the Modules dirC modules in the Modules dirtopic-SSLtype-crashA hard crash of the interpreter, possibly with a core dumpA hard crash of the interpreter, possibly with a core dump
Description
Crash report
import ssl
ctx = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
del ctx.keylog_filename_PySSLContext_set_keylog_filename() in Modules/_ssl/debughelpers.c does not check the value for NULL and passes it to Py_fopen().
It should raise an AttributeError instead, like the setters generated by Argument Clinic in Modules/_ssl.c.
The same code is in 3.13, 3.14 and 3.15.
Linked PRs
- gh-156099: Fix a crash when deleting SSLContext.keylog_filename #156103
- [3.15] gh-156099: Fix a crash when deleting SSLContext.keylog_filename (GH-156103) #156148
- [3.14] gh-156099: Fix a crash when deleting SSLContext.keylog_filename (GH-156103) #156149
- [3.13] gh-156099: Fix a crash when deleting SSLContext.keylog_filename (GH-156103) #156150
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
3.13only security fixesonly security fixes3.14bugs and security fixesbugs and security fixes3.15bugs and security fixesbugs and security fixes3.16new features, bugs and security fixesnew features, bugs and security fixesextension-modulesC modules in the Modules dirC modules in the Modules dirtopic-SSLtype-crashA hard crash of the interpreter, possibly with a core dumpA hard crash of the interpreter, possibly with a core dump
Activity
gh-156099: Fix a crash when deleting SSLContext.keylog_filename (GH-1…
[3.14] gh-156099: Fix a crash when deleting SSLContext.keylog_filename (
[3.13] gh-156099: Fix a crash when deleting SSLContext.keylog_filename (
[3.15] gh-156099: Fix a crash when deleting SSLContext.keylog_filename (