Skip to content

Repeated definition of PY_BUILTIN_HASHLIB_HASHES in configure.ac #122571

Closed
Closed
Repeated definition of PY_BUILTIN_HASHLIB_HASHES in configure.ac#122571
Labels
buildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

Description

@msprotz
msprotz
opened on Aug 1, 2024

Bug report

Bug description:

The PY_BUILTIN_HASHLIB_HASHES variable is defined twice in configure.ac, which
results in the corresponding #define appearing twice in the autoconf
confdefs.h, which results in an unconditional compile error, meaning the test
isn't testing what it is supposed to test.

Found via #119316

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

Activity

  1. msprotz
    added
    type-bugAn unexpected behavior, bug, or error
    on Aug 1, 2024
  2. erlend-aasland
    added
    buildThe build process and cross-build
    on Aug 6, 2024
  3. erlend-aasland
    added a commit that references this issue on Aug 6, 2024

    gh-122571: Remove duplicate definition of PY_BUILTIN_HASHLIB_HASHES i…

    b5e142b
  4. miss-islington
    added a commit that references this issue on Aug 6, 2024

    pythongh-122571: Remove duplicate definition of PY_BUILTIN_HASHLIB_HA…

    09a6982
  5. brandtbucher
    added a commit that references this issue on Aug 7, 2024

    pythongh-122571: Remove duplicate definition of PY_BUILTIN_HASHLIB_HA…

    ac54f8d
  6. blhsing
    added a commit that references this issue on Aug 22, 2024

    pythongh-122571: Remove duplicate definition of PY_BUILTIN_HASHLIB_HA…

    ad03484
  7. Yhg1s
    added a commit that references this issue on Sep 2, 2024

    [3.13] gh-122571: Remove duplicate definition of PY_BUILTIN_HASHLIB_H…

    8a4f708

  8. picnixz commented on Oct 6, 2024

    @picnixz
    picnixz
    on Oct 6, 2024
    Member

    Closing since it was completed and backported (not to 3.12, per #122572 (comment)).

  9. picnixz
    closed this as completedon Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions