Repository navigation
RotatingFileHandler can create empty backups #116263
Description
Bug report
In the following example the rotating file handler writes the message in file "test.log" and creates an empty backup file "test.log.1".
import logging.handlers
fh = logging.handlers.RotatingFileHandler('test.log', maxBytes=100, backupCount=1)
fh.emit(logging.makeLogRecord({'msg': 'x'*100}))
fh.close()I think creating an empty backup file is meaningless. shouldRollover() should return False if self.stream.tell() returns 0 (it happens for just created file).
Linked PRs
Metadata
Metadata
Assignees
Labels
Projects
- Status
Activity
pythongh-116263: Do not rollover empty files in RotatingFileHandler
gh-116263: Do not rollover empty files in RotatingFileHandler (GH-122788
pythongh-116263: Do not rollover empty files in RotatingFileHandler (p…
pythongh-116263: Do not rollover empty files in RotatingFileHandler (p…
pythongh-116263: Do not rollover empty files in RotatingFileHandler (p…
[3.13] gh-116263: Do not rollover empty files in RotatingFileHandler (G…
[3.12] gh-116263: Do not rollover empty files in RotatingFileHandler (G…