Repository navigation
"wikipedia" turtledemo example in docs is supposed to be "rosette" #102135
Description
The turtle module documentation, at this link has a section on turtledemo. It says the demo scripts are
- bytedesign
- chaos
- clock
- colormixer
- forest
- fractalcurves
- lindenmayer
- minimal_hanoi
- nim
- paint
- peace
- penrose
- planet_and_moon
- round_dance
- sorting_animate
- tree
- two_canvases
- wikipedia
- yinyang
The second last example is wrong. In my Python, the turtledemo list shows wikipedia as rosette. Is the rosette title wrong, or is it the wikipedia title?
Activity
hugovk commentedon Feb 22, 2023
Using
git log --all --full-history -- Lib/turtledemo/wikipedia.py, I see the file was renamed in #58325 / #8002 but the documentation was updated:Would you like to create a PR to update the docs?
The file to change is https://github.com/python/cpython/blob/main/Doc/library/turtle.rst
Rhaxier commentedon Feb 22, 2023
Yeah, I will
hugovk commentedon Feb 22, 2023
Great! You can create a PR by clicking "Compare" next to the patch-1 branch at https://github.com/UndoneStudios/cpython/branches and then the green "Create pull request".
One suggestion: let's keep them in alphabetical order.
Rhaxier commentedon Feb 22, 2023
Isn't it already in alphabetical order?
hugovk commentedon Feb 22, 2023
Yes, the original "two_canvases, wikipedia, yinyang" is in alphabetical order, but "two_canvases, rosette, yinyang" isn't.
Rhaxier commentedon Feb 22, 2023
Well, keeping it in alphabetical order is a pain. Hold on as I try to modify it...
Rhaxier commentedon Feb 22, 2023
I'm a little busy right now, so I can't make the PR request
hugovk commentedon Feb 22, 2023
It's been broken for
115 years, so no rush :)The thing to do would be to cut the three lines 2460-2462 and paste them at line 2447, before round_dance.
Rhaxier commentedon Feb 22, 2023
Thanks a lot for that tip!
Rhaxier commentedon Feb 22, 2023
I... don't think it went well:
#102137
hugovk commentedon Feb 22, 2023
Thanks, that's looking good, I'll review it!
gh-102135: Update turtle docs to rename wikipedia demo to rosette (#1…
pythongh-102135: Update turtle docs to rename wikipedia demo to roset…
pythongh-102135: Update turtle docs to rename wikipedia demo to roset…
hugovk commentedon Feb 22, 2023
Thanks again for reporting and fixing this 🚀
[3.10] gh-102135: Update turtle docs to rename wikipedia demo to rose…
[3.11] gh-102135: Update turtle docs to rename wikipedia demo to rose…
terryjreedy commentedon Feb 22, 2023
Thanks for catching this. I changed the name 5 years ago and did not notice the reference in the doc.
Merge branch 'main' into lockfreecp
pythongh-102135: Update turtle docs to rename wikipedia demo to roset…