Repository navigation
Conversation
Author
|
The CI failure seems unrelated (something to do with https://leafletjs.com/examples/extending-1-classes/ now 404-ing) |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there :)
At first I was planning on improving static type coverage here, but I then noticed that you were still supporting two EOL Python versions: Python 3.9 has been end of life (EOL) since 2025-10-31, and Python 3.10 since 2026-10-01. They don't receive any security updates anymore, aand without them, the type annotations can be written using modern typing syntax, which helps a lot for readability. So I figured that improving type coverage would be a lot easier if I'd just drop these EOL Python versions first, so here I am :)
A consequence of the new
3.11lower bound is thatruff checkstarted reporting 149 new (pyupgrade) errors. I auto-fixed most of them usingruff check --fix, leaving 4 errors that I had to fix by hand. These required marking type aliases withTypeAliasso that mypy understands that e.g."Figure | Div | Popup"is a type expression, rather than a string constant.When I ran ruff and mypy locally, they seemed happy. I wasn't able to run all pytest tests though; The test failures were mostly in
tests/seleniumandtests/snapshots, and also one intests/test_repr. But as far as I can tell, these failures seem unrelated to this PR.