Skip to content

A few more more Tox cleanup bits - #121

Merged
wsanchez merged 1 commit into
masterfrom
tox-cleanup
Apr 6, 2020
Merged

wsanchez merged 1 commit into
masterfrom
tox-cleanup

Conversation

@wsanchez

@wsanchez wsanchez commented Apr 2, 2020

Copy link
Copy Markdown
Contributor

While merging #106 forward, I found a few more bits to clean up.

Comment thread tox.ini
sphinx-build \
-b html -d "{envtmpdir}/doctrees" \
"{toxinidir}/docs" \
"{toxworkdir}/docs/html"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to match other projects, and similar to /htmlcov/.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, other hyper projects, or which other projects?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Klein in particular; I'm trying to keep the configs relatively similar for sanity.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me whispers "we need a tool to keep them in sync"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I KNOW

@mahmoud mahmoud mentioned this pull request Apr 5, 2020

@glyph glyph left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wsanchez
wsanchez merged commit 9a6607f into master Apr 6, 2020
@wsanchez
wsanchez deleted the tox-cleanup branch April 6, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants