Repository navigation
Handle decoding errors in file inspection during filtering #3373
Description
Sentry Issue: BOT-436
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf5 in position 14: invalid start byte
File "bot/exts/filtering/filtering.py", line 237, in on_message
await _extract_text_file_content(a)
File "bot/exts/filtering/filtering.py", line 73, in _extract_text_file_content
file_lines = file_content_bytes.decode(file_encoding).splitlines()
Unhandled exception in on_message.
It's not obvious to me what would be appropriate here. Block the file? Ignore unknown characters?
Activity
mbaruh commentedon Aug 17, 2025
@swfarnsworth your input would be appreciated
swfarnsworth commentedon Aug 17, 2025
@mbaruh I think this is the first time this has happened?
We could just add
errors='ignore'.wookie184 commentedon Sep 15, 2025
In this case it seems like a user uploaded a zip file with a txt extension. I assume the same could happen if you tried to share an executable with a
txtextension? If so it could be an indication of somebody trying to bypass filters, though seemlingly rare so not a high priority.onerandomusername commentedon Oct 22, 2025
What was the value of file_encoding in this error?
wookie184 commentedon Nov 20, 2025
"utf-8"