Repository navigation
Do not retry RaisesGroup check on contained exceptions - #15276
Open
theman6660 wants to merge 1 commit into
Open
theman6660 wants to merge 1 commit into
theman6660 wants to merge 1 commit into
Conversation
Co-authored-by: Codex <noreply@openai.com>
pyba-chronographer
Bot
added
the
bot:chronographer:provided
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
RaisesGroupcheck returns False, failure-message construction currently retries the callback on a contained exception. A callback expecting an exception group can then raiseAttributeError, and callbacks with side effects can run twice.Remove that diagnostic probe so the check is called only on the matched group. The failed-check message is retained; the suggestion inferred by calling the callback on the wrong type is removed.
Regression tests cover ExceptionGroup and BaseExceptionGroup, True/False check results, a single callback invocation, and propagation of exceptions raised by the callback itself. The new failing-check cases reproduce the bug against the original source. Validation: 71 raises/raises_group tests passed, and changed-file pre-commit checks including mypy passed.
Fixes #14324.
AI assistance: The implementation, tests, and this description were prepared using OpenAI Codex at my request.