Skip to content

Run mypy job with Python 3.11 once it is supported #240

Closed

Description

@ricardoV94

Description

We should revert c3bfe66 once mypy is sorted out (and if it's not mypy fault, then whatever we are doing wrong).

Maybe related to python/mypy#12840, maybe we need to open a new issue over there?

Activity

  1. changed the title [-]Run mypy job in Python 3.11 once it is supported[/-] [+]Run mypy job with Python 3.11 once it is supported[/+] on Mar 10, 2023
  2. ricardoV94 commented on Mar 11, 2023

    @ricardoV94
    MemberAuthor

    I didn't save the run, but this was the error:

     [pytensor/link/c/exceptions.py]
     pytensor/link/c/exceptions.py:1: error: Module "setuptools._distutils.errors" has no attribute "CompileError"
    

    Even though it's there in main
    https://github.com/pypa/setuptools/blob/245d72a8aa4d47e1811425213aba2a06a0bb64fa/setuptools/_distutils/errors.py#L112-L113

  3. ricardoV94 commented on Apr 17, 2023

    @ricardoV94
    MemberAuthor

    It also cropped up on a Python 3.10 job now, so it must be something else: https://github.com/pymc-devs/pytensor/actions/runs/4712555504/jobs/8357675677?pr=276

    @michaelosthege do you have any ideas?

  4. maresb commented on Apr 17, 2023

    @maresb
    Collaborator

    Looks like a problem with setuptools-types which would be fixed by python/typeshed#10057 and #277

  5. ricardoV94 commented on Apr 17, 2023

    @ricardoV94
    MemberAuthor

    Awesome 😎

  6. maresb commented on Apr 17, 2023

    @maresb
    Collaborator

    My typeshed PR has already been merged. A quick glance at their GH Actions suggests that there will soon be an automatic release to https://pypi.org/project/types-setuptools/#history. Once that's out, #277 should pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions