Repository navigation
Use command-line names in missing-argument errors - #1097
Open
Hugohong258 wants to merge 1 commit into
Open
Hugohong258 wants to merge 1 commit into
Hugohong258 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a required
param_1argument is exposed asparam-1on the command line, omitting it reports the Python attribute name instead of the CLI name. Use the argument's first public name in that error. Regression coverage includes dashed names, an unrelated internal attribute name, and an untransformed-name control. Fixes #1017.Validation: two new cases fail before the fix, with the control passing. On WSL Linux/Python 3.14.4, 216 related parser/task tests pass and 2 are skipped. Real CLI checks on Windows/Python 3.12.3 and Linux/Python 3.14.4 confirm both the missing-argument error and successful
--param-1/--param-2calls. Black 22.8, the pinned Flake8 4 checks, and mypy 0.971 over all 48 package source files pass. Flake8 used an external entry-point API adapter for this Python 3.12 host, excluding unrelated host plugins. The full unit suite, integrations and older-runtime CI matrix were not run. Based on the 2.2 release line per the contribution guide.