Repository navigation
Conversation
no_header[:-test_offset] is empty when test_offset is 0, so the decompressor never reaches the end of the stream and the eof check skips the assertion. Slice up to len(no_header) - test_offset and assert eof.
ptweezy
force-pushed
the
test-raw-deflate-offset
branch
from
October 24, 2026 17:05
a8b9fc6 to
dcad7cf
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_igzip_decompressor_raw_deflate_unused_data_zlibandtest_igzip_decompressor_raw_deflate_unused_data_gzipcuttest_offsetbytes off the trailer withno_header[:-test_offset]. Whentest_offsetis 0, that slice is empty, so the decompressor never reaches the end of the stream, andif igzd.eof:skips the assertion. That check would also hide a bug that stopseoffrom being set.The tests now slice up to
len(no_header) - test_offsetand assertigzd.eof. All 14 cases pass, including the two withtest_offset0, which asserted nothing before.This PR changes only tests, so it has no CHANGELOG entry.
Checklist