Repository navigation
Conversation
A failed job made fewer barrier waits than the other jobs, so when the jobs ran out, the other threads waited at the barrier forever and the test never finished. Create the barrier in the test function with a 10 s timeout, because a module-level barrier would stay broken and also fail the next parameter set.
ptweezy
force-pushed
the
test-barrier-timeout
branch
from
October 24, 2026 17:05
4790836 to
f3b243e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A job in
test_isal_compress_decompress_threadedthat fails makes fewerbarrier.wait()calls than the other jobs. When the jobs run out, the remaining threads wait at the barrier for a thread that has no job left, so the test never finishes and never reports theAssertionError. I checked this by making onedecompress()call return wrong data.The test now creates its own barrier with a 10 s timeout. A module-level barrier would stay broken and also fail the next parameter set. With the same wrong data, the test fails with the
AssertionErrorafter about 10 s. Under ThreadSanitizer with free-threaded CPython 3.14.8t, the longest wait at the barrier was 71 ms with 4 CPUs, 0.3 s with 1 CPU, and 0.7 s with a quarter of a CPU.This PR changes only tests, so it has no CHANGELOG entry.
Checklist