Repository navigation
Conversation
The command line tests assigned sys.argv and sys.stdin directly, and pytest does not restore them between tests. test_compress_infile_out_file_prompt passed only because an earlier test left an exhausted sys.stdin behind, and it failed when run alone. Set both with monkeypatch or mock.patch.object(), and give the prompt test an empty sys.stdin.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command line tests in
tests/test_igzip.pyassignsys.argvandsys.stdindirectly, and pytest doesn't restore them between tests.test_compress_infile_out_file_promptpasses only because an earlier test leaves an exhaustedsys.stdinbehind. Run alone or with-k prompt, it fails:The tests now set both attributes with
monkeypatch, and the prompt test gets an emptysys.stdin. Intests/test_gzip_compliance.py,TestCommandLine.test_decompress_infile_outfilenow setssys.argvwithmock.patch.object(). The leakedsys.argvbreaks no test today, but these tests now restore it too.On
develop, 5 of 40 random orders oftests/test_igzip.py(pytest-randomlyseeds 1 to 40) fail. With this PR, none do.This PR changes only tests, so it has no CHANGELOG entry.
Checklist