Repository navigation
DEV: Keep the benchmark page on main - #4332
Open
MartinThoma wants to merge 2 commits into
Open
MartinThoma wants to merge 2 commits into
MartinThoma wants to merge 2 commits into
Conversation
The benchmark page was only stored on gh-pages, so changes to it could not be reviewed in a PR. Move it unchanged to docs/benchmark-page/ and let the benchmark workflow copy it to gh-pages after each run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MartinThoma
marked this pull request as ready for review
November 1, 2026 07:54
Add a README to docs/benchmark-page/ that says where the page is served and how it gets there, and exclude the folder from the Sphinx build. Rename the job to publish, as on the readable-bench branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4332 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 59 59
Lines 11964 11964
Branches 2271 2271
=======================================
Hits 11803 11803
Misses 84 84
Partials 77 77 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark page was only stored on gh-pages, so changes to it could not be reviewed in a PR.
This PR moves the page unchanged to docs/benchmark-page/
The benchmark workflow copies it the page gh-pages after each run.
Note: I've closed #4291 as I think it's easier to review this in 2-3 separate PRs.