Repository navigation
ROB: Handle a Tf operator with a missing size or no operands in layou… - #4228
Merged
stefan6419846 merged 1 commit intoOct 20, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4228 +/- ##
=======================================
Coverage 98.18% 98.19%
=======================================
Files 59 59
Lines 11820 11827 +7
Branches 2226 2226
=======================================
+ Hits 11606 11613 +7
Misses 118 118
Partials 96 96 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefan6419846
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In layout mode, a
Tfoperator without its size operand (/F1 Tf) madeextract_text()raiseIndexError, and so did a bareTfwith no operands at all. Plain mode already handles both.Now a missing or non-numeric size keeps the current font size, and a missing font name resolves to the same placeholder font as an unknown one (see
resolve_font()), so the rest of the page is still extracted. The two call sites share a small helper,set_font_operation().