Repository navigation
BUG: Check the box names assigned to the area and clip preferences - #4014
Merged
stefan6419846 merged 3 commits intoAug 26, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4014 +/- ##
=======================================
Coverage 98.00% 98.00%
=======================================
Files 57 57
Lines 11124 11126 +2
Branches 2086 2086
=======================================
+ Hits 10902 10904 +2
Misses 124 124
Partials 98 98 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefan6419846
requested changes
Aug 26, 2026
/ViewArea, /ViewClip, /PrintArea and /PrintClip were each declared with an empty list of acceptable values, so any name was written through and the generated docstrings read 'Acceptable values: []'. All four name one of the five page boundaries, which PageAttributes already defines, so they now reject anything else the way direction and duplex do.
RavSinghChandan
force-pushed
the
validate-box-name-preferences
branch
from
August 26, 2026 10:06
25e7d23 to
8083adf
Compare
Contributor
Author
|
Both done. Dropped the alias, and the box names are now a BOX_NAMES constant next to f_obj, which the tests parametrise over so the five names are only written once. |
Contributor
Author
|
Both done - dropped the alias, and the box names are now a BOX_NAMES constant next to f_obj, which the tests parametrise over so the five names are only written once. Thanks for fixing the spacing, that was mine from resolving the conflict. |
stefan6419846
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/ViewArea,/ViewClip,/PrintAreaand/PrintClipare each declared with an empty list of acceptable values:So any name is written through unchecked, and the generated docstrings read "Acceptable values: []":
All four name one of the five page boundaries, which
PageAttributesalready defines, so the allowed set is taken from there rather than spelled out again.directionandduplexbeside them already reject a value outside their set.Reverting the change fails the four new tests