Repository navigation
BUG: Reject a non-positive number when building a Roman numeral - #4005
Merged
stefan6419846 merged 1 commit intoAug 25, 2026
Merged
Conversation
number2uppercase_roman_numeral(-1) returned 'CMXCIX' and 0 returned an empty string: the loop subtracts each value it emits and stops once the remainder reaches zero, which a negative input satisfies after one pass over the table. number2uppercase_letter and number2lowercase_letter beside it already refuse a non-positive number, and index2label catches ValueError from the mapping function to fall back to the page position, so a file with /St 0 now reports a malformed entry rather than a nonsense numeral.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4005 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 57 57
Lines 11106 11108 +2
Branches 2080 2081 +1
=======================================
+ Hits 10882 10884 +2
Misses 125 125
Partials 99 99 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefan6419846
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
number2uppercase_roman_numeral(-1)returns'CMXCIX'and0returns an empty string:The loop subtracts each value it emits and stops once the remainder reaches zero, which a negative input satisfies after a single pass over the table.
number2uppercase_letterandnumber2lowercase_letterbeside it already refuse a non-positive number with the same message, so this brings the four numbering styles in line.index2labelalready catchesValueErrorfrom the mapping function and falls back to the page position, so a file carrying/St 0now logs "Ignoring malformed page label entry" rather than labelling a pageCMXCIX.Reverting the change fails the three new tests