Repository navigation
STY: Use the FfBits enum instead of a plain integer for form field flags - #4003
Merged
Merged
Conversation
update_page_form_field_values takes its flags as FieldDictionaryAttributes FfBits, and the docstring points readers at that enum, but the tests passed a bare 1 in five places. FfBits(1) is ReadOnly, so spelling it out says what the call is asking for. Same shape as py-pdf#3997.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4003 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 57 57
Lines 11106 11106
Branches 2080 2080
=======================================
Hits 10882 10882
Misses 125 125
Partials 99 99 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefan6419846
requested changes
Aug 24, 2026
The surrounding test modules import constants unabbreviated, and the lines still fit within the configured limit.
Contributor
Author
|
Fair enough, spelled it out. The lines are longer but still inside the 120 character limit, and it matches how the other test modules import constants. |
stefan6419846
changed the title
stefan6419846
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_page_form_field_valuestakes its flags asFieldDictionaryAttributes.FfBitsand the docstring points readers at that enum, but the tests passed a bare1in five places.FfBits(1)isReadOnly, so spelling it out says what the call is actually asking for rather than leaving the reader to look up the bit.Same shape as #3997