Repository navigation
BUG: Resolve the font resource before building a Font from it - #4002
Merged
stefan6419846 merged 1 commit intoAug 25, 2026
Merged
Conversation
Font.from_font_resource takes a DictionaryObject and reads it with .get(), but two callers hand over the raw entry from the /Font resource dictionary, which is an IndirectObject. It works only because IndirectObject forwards unknown attributes to the object it points at. The third caller in _page.py already calls get_object() first, so the other two now do the same.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4002 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 57 57
Lines 11106 11106
Branches 2080 2080
=======================================
Hits 10882 10882
Misses 125 125
Partials 99 99 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefan6419846
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Font.from_font_resourcetakes aDictionaryObjectand reads it with.get(), but two callers hand over the raw entry from the/Fontresource dictionary, which is anIndirectObject.It works today only because
IndirectObjectforwards unknown attributes to the object it points at, so the.get()calls land on the resolved dictionary by accident rather than by design.The third caller in
_page.pyalready callsget_object()first, so the other two now do the same. A typeguard run reports four failures for this before the change and none after