Repository navigation
STY: Type the XMP stream as StreamObject rather than ContentStream - #3995
Merged
Merged
Conversation
XmpInformation is constructed from the /Metadata stream, which is a DecodedStreamObject. ContentStream is a sibling of that class rather than a parent, so the annotation could never hold. The class only calls get_data, set_data and write_to_stream, all of which StreamObject provides.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3995 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 57 57
Lines 11098 11098
Branches 2078 2078
=======================================
Hits 10874 10874
Misses 125 125
Partials 99 99 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefan6419846
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XmpInformationis constructed from the/Metadatastream, which is aDecodedStreamObject.ContentStreamis a sibling of that class rather than a parent, so the annotation could never hold — the same shape as #3972.The class only calls
get_data,set_dataandwrite_to_stream, all of whichStreamObjectprovides. 18 typeguard failures before, none after.