Repository navigation
Conversation
openvox_bootstrap 1.8.0 adds `manage_release_package` to its install task, so bootstrap::install_packages now always uses that task, passing `manage_release_package => $manage_repos`, instead of falling back to Bolt's `package` task when `manage_repos` is false. Pin openvox_bootstrap 1.8.0 in the Bolt project and require it in the bootstrap module's metadata. Fixes puppet-bootstrap#211 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #211.
openvox_bootstrap 1.8.0 adds
manage_release_packageto its install task (voxpupuli/puppet-openvox_bootstrap#78). Sobootstrap::install_packagesnow always usesopenvox_bootstrap::installwithmanage_release_package => $manage_repos. Before, it fell back to Bolt'spackagetask whenmanage_reposwas false.Boltdir/bolt-project.yamlandBoltdir/Puppetfile, and requires>= 1.8.0in the bootstrap module's metadata. The spec fixtures already pull the latest from the Forge.bolt module install --forcecan't resolve the current pins. choria-mcollective 0.15.0 wants puppet-systemd< 10.0.0, but 11.0.0 is pinned. That conflict is already onproduction.versionbecomeslatest, as it already did withmanage_repos, and the task leaves an installed agent alone.manage_release_package=false, the task doesn't runapt-get update. Neither did thepackagetask fallback, so behaviour on those hosts is the same as before.Testing
On fresh CentOS Stream 9 VMs, I added the OpenVox 9 repo by hand from the release RPM's contents, without installing
openvox9-release, to simulate a Satellite. Then I ranbasic_aiowithmanage_repos=false postgres_source=osand the rest of the demo's arguments:openvox_bootstrap::installand logged "Not managing the release package; using the configured package repositories". Thepackagetask never ran.openvox9-releaseis still not installed on either host. openvox-agent, openvox-server, openvoxdb, openvoxdb-termini, and PostgreSQL 16 from the AppStream module are installed.The acceptance workflow on this PR covers the default
manage_repos=truepath.🤖 Generated with Claude Code