Repository navigation
Conversation
Member
|
Same here, @orsissimo, if you can rebase 🙏 |
orsissimo
force-pushed
the
fix/post-process-null-agents
branch
from
October 31, 2026 12:50
3a05c23 to
6d5a55b
Compare
orsissimo
marked this pull request as ready for review
October 31, 2026 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SWARM_AGENTSwhenpost_processis absent or null, so image builds do not install a CLI that no container runs.Changes
launch.sh: add the post-process driver only for non-null sections, including empty objects and sections without a prompt.tests/test_launch.sh: add four cases in section 38 for absent and null sections, an unused top-level driver, and a configured post-process using the default driver.CHANGELOG.md: document the fix under Unreleased.Self-review checklist
Test plan
tests/test_launch.sh: 234 passed. With master'slaunch.sh, the absent, null, and unused top-level driver checks fail; the configured default check passes both ways../tests/test.sh --unit: macOS Bash 3.2.57, 1388 tests; Ubuntu 24.04 Bash 5.2, 1400 tests. Each run covered 13 files with 0 failures.shellcheck -s bash --severity=warning launch.sh tests/test_launch.sh: clean../tests/test.sh --all: not run; requires an API key.