[sstrigler]

An example says more than ...

xmpp:decode(fxml_stream:parse_element(<<"<report xmlns='urn:xmpp:reporting:1' reason='urn:xmpp:reporting:abuse'><report-origin/><stanza-id  xmlns='urn:xmpp:sid:0' by='romeo@example.net' id='28482-98726-73623'/><text xml:lang='de'>hallo</text></report>">>)).
#report{reason = abuse,
        text = [#text{lang = <<"de">>,data = <<"hallo">>}],
        'report-origin' = true,'third-party' = false,
        'stanza-ids' = [#stanza_id{by = #jid{user = <<"romeo">>,
                                             server = <<"example.net">>,resource = <<>>,
                                             luser = <<"romeo">>,lserver = <<"example.net">>,
                                             lresource = <<>>},
                                   id = <<"28482-98726-73623">>}]}

[sstrigler]

Or should I be using underscores in attribute names, like third_party etc instead?

[badlop]

Looking at the xmpp_codec.spec file, the ref labels that have several words separate them with _, and none uses -. So, yes, better to use underscores in those ref labels, at least for coherence in that file.

The string used in the final XML is correctly set in

#elem{name = <<"third-party">>,

[sstrigler]

Thanks, that's what I meant. I've updated the PR accordingly. Now it looks like this:

(ejabberd@localhost)3> xmpp:decode(fxml_stream:parse_element(<<"<report xmlns='urn:xmpp:reporting:1' reason='urn:xmpp:reporting:abuse'><report-origin/><stanza-id  xmlns='urn:xmpp:sid:0' by='romeo@example.net' id='28482-98726-73623'/><text xml:lang='de'>hallo</text></report>">>)).
#report{reason = abuse,
        text = [#text{lang = <<"de">>,data = <<"hallo">>}],
        report_origin = true,third_party = false,
        stanza_ids = [#stanza_id{by = #jid{user = <<"romeo">>,
                                           server = <<"example.net">>,resource = <<>>,
                                           luser = <<"romeo">>,lserver = <<"example.net">>,
                                           lresource = <<>>},
                                 id = <<"28482-98726-73623">>}]}

[sstrigler]

Beware, maybe because I force pushed the automated make spec xdata didn't run.

Also for some odd reason CI is acting up. Should I just delete this PR and try with a new one?

[badlop]

Don't worry, let's merge, it may generate then, or can be made manually.