Repository navigation
feat(policy): permit a pinned private endpoint for policy egress - #1260
Merged
shaneutt merged 1 commit intoSep 25, 2026
Merged
Conversation
shaneutt
previously approved these changes
Sep 25, 2026
shaneutt
left a comment
shaneutt
left a comment
Member
There was a problem hiding this comment.
All my comments are pretty minor. Once they are resolved, 👍
Policy egress refuses a callout that resolves only to non-public addresses; the one override, allow_private_idp, opens the whole callout pool to private space. Add a trusted_private_endpoints allowlist on the policy filter so a single in-cluster host can be reached at a private address while every other callout stays public-only. A matched host is still refused a link-local address, classified via ppe-core's private_address_reason rather than re-derived, so the IPv4-mapped and NAT64 embedded IPv6 forms stay covered. allow_private_idp is unchanged. Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
hexfusion
force-pushed
the
feat/policy-egress-pinned-endpoints
branch
from
September 25, 2026 12:31
33150a9 to
12624e5
Compare
shaneutt
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a per-target private-endpoint allowlist to the policy filter's outbound HTTP transport.
Policy egress refuses a callout that resolves only to non-public addresses (#1127). The one override,
allow_private_idp, opens the whole policy callout pool to private space. This adds a narrower alternative: atrusted_private_endpointslist on the policy filter. A callout gets a private or loopback address only when its target host matches an entry; every other callout stays public-only, so the guard is narrowed per-target, not disabled.A matched host is still refuses a link-local address, so a pin cannot reach cloud metadata. The link-local test reads the reason from ppe-core
private_address_reasonrather than re-deriving it, so the IPv4-mapped and NAT64 embedded IPv6 forms stay covered.allow_private_idpis unchanged and remains the coarse escape hatch.This is the address-guard axis of reaching a cluster-internal policy IdP. It composes with #1157 (CA and client-certificate trust): #1157 makes the endpoint's certificate verifiable, this makes its address reachable at all. It is separate from #1156, which is cert verification for an IP-literal target (IP-SAN); this change gates on a DNS host name and does no certificate verification. Concrete consumer: the api-key resolver in praxis-proxy/policy#125, whose HTTP backend validates against a cluster-internal maas-api key-validation URL.
Which issue(s) does this relate to?
Fixes #1259
Relates to #1157 (composes with it) and #1127. Separate from #1156 (IP-SAN).
Checklist
git commit -s)make lint && make test && make test-integrationpasses locallyDoes this introduce a breaking change?
No.
trusted_private_endpointsdefaults to empty, so existing configs behave exactly as before.