Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 Walkthrough
Merge Risk: 🔵 Low · up to The docs contain a spelling error and wording that could confuse Premium users about v1beta2 eligibility. These are bounded documentation risks, with no runtime routing impact evidenced here, so merging is reasonable with the wording fixes tracked. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review details
Pre-merge checks |
|
|
@zhangpeijin-milo: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: pingcap/docs/.coderabbit.yaml
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
eeaaa70c-e649-4f47-88aa-d64cd434a9f1
📒 Files selected for processing (3)
api/tidb-cloud-api-overview.mdapi/tidb-cloud-api-v1beta1.mdapi/tidb-cloud-api-v1beta2.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
|
|
||
| - Cluster-level resources: | ||
| - [TiDB Cloud Starter or Essential Cluster](https://docs.pingcap.com/tidbcloud/api/v1beta1/serverless): manage clusters, branches, data export tasks, and data import tasks for TiDB Cloud Starter or Essential clusters. | ||
| - [TiDB Cloud Starter or Essential Cluster](https://docs.pingcap.com/tidbcloud/api/v1beta1/serverless): manage clusters, branches, data export tasks, and data import tasks for TiDB Cloud Starter or Essential clusers (v8.5 or earlier). |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Correct the misspelling clusers.
Replace it with clusters.
- [TiDB Cloud Starter or Essential Cluster](https://docs.pingcap.com/tidbcloud/api/v1beta1/serverless): manage clusters, branches, data export tasks, and data import tasks for TiDB Cloud Starter or Essential clusters (v8.5 or earlier).
As per path instructions, provide a GitHub committable suggestion when the replacement is exact.
Source: Path instructions
|
|
||
| > **Note:** | ||
| > | ||
| > TiDB Cloud API v1beta2 is only available for Essential instances running version CLOUD.202603.x or later. For Essential instances on version v8.5 or earlier, please use the TiDB Cloud API [v1beta1](/api/tidb-cloud-api-v1beta1.md) No newline at end of file |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Scope the version rule to Essential instances.
The page lists Premium and Essential support on Lines 8–16. This note says v1beta2 is available only for qualifying Essential instances, which makes the Premium API scope unclear. State the version routing specifically for Essential instances.
> For Essential instances running version CLOUD.202603.x or later, use TiDB Cloud API v1beta2. For Essential instances running version v8.5 or earlier, use TiDB Cloud API [v1beta1](/api/tidb-cloud-api-v1beta1.md).
As per path instructions, provide a GitHub committable suggestion when the replacement is exact.
Source: Path instructions
First-time contributors' checklist
What is changed, added, or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
CLOUD.202603.xor later, and v1beta1 for version 8.5 or earlier.