Repository navigation
docs: remove outdated CentOS 7 quick start recommendation - #24256
doc-claw-bot wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 Walkthrough
Merge Risk: 🔵 Low · up to Add a warning that the cleanup command deletes cluster data. The potential impact is limited to readers who run it on a cluster containing data they intend to keep. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review details
Pre-merge checks |
|
There was a problem hiding this comment.
🔇 Additional comments (1)
quick-start-with-tidb.md-292-292 (1)
292-292: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.Specify ARM 64 explicitly.
The linked requirements list ARM 64 and require a 64-bit CPU. “ARM architectures” can include 32-bit ARM, so this sentence overstates the supported architectures.
- Currently, the TiUP cluster supports deploying TiDB on the x86_64 (AMD64) and ARM 64 architectures. For supported operating system and CPU architecture combinations, see [OS and platform requirements](/hardware-and-software-requirements.md#os-and-platform-requirements).As per path instructions: “For every actionable issue, provide a GitHub committable suggestion block containing the exact replacement text whenever the fix can be safely and completely applied to contiguous lines in the diff.”
Source: Path instructions
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: pingcap/docs/.coderabbit.yaml
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
cfe41530-ea2e-4e3b-b10c-7a6b7471929e
📒 Files selected for processing (1)
quick-start-with-tidb.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: pingcap/docs/.coderabbit.yaml
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
7b4158fd-f06b-4381-8d5c-c0056cc34228
📒 Files selected for processing (2)
basic-features.mdquick-start-with-tidb.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
| tiup cluster stop <cluster-name> | ||
| ``` | ||
|
|
||
| 2. Destroy the cluster after it is stopped: |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
State that destroying the cluster deletes its data.
tiup cluster destroy deletes service log, deployment, and data directories. State this effect before the command so readers know this cleanup step removes more than running services.
2. Destroy the cluster after it is stopped. This command deletes the cluster's log, deployment, and data directories.
What is changed, added, or deleted? (Required)
quick-start-with-tidb.mdwith guidance to use a TiDB-supported Linux distribution.tiup cluster stopandtiup cluster destroyinstead of the Playground-onlyCtrl+Candtiup clean --allflow.basic-features.md: markauthentication_ldap_saslas supported in v7.1 and correctTransparent layer securitytoTransport Layer Security.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit