Disallow assertEmpty with strict rule disallowedEmpty set

hey there

I am currently trying to activate the disallowedEmpty rule of the strict package in our code base (over 1k issues 🎉🤯🙈)

While doing that, I found, that the usage of assertEmpty is not affected by this rule. Is this intentionally? Or do you think, it would be an addition that actually makes sense and would make it consistent?

Happy to hear your feedback on this 🙂

best regards 👋

I agree and I think we are doing something similar with another rule already in

phpstan-phpunit/rules.neon

Lines 13 to 14 in 202afe9

    
           PHPStan\Rules\PHPUnit\AssertEqualsIsDiscouragedRule: 
        
           	phpstan.rules.rule: [%strictRulesInstalled%, %featureToggles.bleedingEdge%]

I am not sure we can/should utilize the very fine grained disallowedEmpty though.. maybe strictRulesInstalled is enough

I'd like to check what assertEmpty actually does and if it's as bad as PHP's empty().

see the implementation of IsEmpty

@ondrejmirtes

hey @ondrejmirtes @staabm

how can we proceed here? If you point me to the right direction, I can try to add this

feat: Discourage assert(Not)Empty if "empty" usage is disallowed

Navigation Menu

Repository navigation

Disallow `assertEmpty` with strict rule `disallowedEmpty` set #270

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	PHPStan\Rules\PHPUnit\AssertEqualsIsDiscouragedRule:
	phpstan.rules.rule: [%strictRulesInstalled%, %featureToggles.bleedingEdge%]

Disallow assertEmpty with strict rule disallowedEmpty set #270

Description

Activity

staabm commented on Dec 17, 2025

ondrejmirtes commented on Dec 17, 2025

staabm commented on Dec 17, 2025

mitelg commented on Mar 31, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Disallow `assertEmpty` with strict rule `disallowedEmpty` set #270