Repository navigation
Improved autocomplete - #126
Merged
Merged
Conversation
Member
Author
There was a problem hiding this comment.
Do not need to lazy initialize any more since the container refactoring.
dantleech
force-pushed
the
autocomplete
branch
from
December 22, 2014 10:12
c8a3d01 to
ba5f5f9
Compare
The autocomplete now includes commands in addition to paths and options.
dantleech
force-pushed
the
autocomplete
branch
from
December 22, 2014 10:29
ba5f5f9 to
ee5f9c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The autocomplete now includes commands in addition to paths and
options.
I was hoping to improve this to support
full/path/au<tab>/completionhowever thereadline_infocommand does not return the current line buffer as documented (it returns the last line). Without this I can only retrieve the last segment of the line buffer (e.g.completion).I notice also that the Symfony shell uses the same method that I tried to use, and that also does not work.
I wonder if I could do something closer to the metal, e.g. like this pr but for the minute this is OK.