Skip to content

Redesign Board Announcements - #174

Draft
iMattPro wants to merge 13 commits into
phpbb-extensions:masterfrom
iMattPro:v2-redesign
Draft

iMattPro wants to merge 13 commits into
phpbb-extensions:masterfrom
iMattPro:v2-redesign

Conversation

@iMattPro

@iMattPro iMattPro commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Redesign and improvements/modernizations to board announcements.

  • Added draft, scheduled, active, expired, and archived lifecycle states with start and end dates.
  • Added public headings, semantic tones, and custom accessible colors.
  • Added group targeting and forum descendant targeting alongside guest, member, and site-wide audiences.
  • Added a simple administrator action to show an announcement again to everyone.
  • Added ACP search, status filters, operational status, duplication, archive, ordering controls, and bulk actions.
  • Redesigned the ACP management and editing screens with responsive controls, accessible action icons, and improved filtering.
  • Added a dedicated administrator permission.
  • Replaced dismissal links with POST requests protected by phpBB form tokens.
  • Added centralized visibility checks and phpbb.boardannouncements.visibility extension event.
  • Removed expiry mutation during page rendering and obsolete expiry cron task; current status is derived from schedule.
  • Preserved existing announcements, ordering, and targeting during upgrade.

This is a WIP - I'm not sure yet if this should be deferred to a phpBB 4 target or if this would be worth doing for 3.3.x too.

@iMattPro
iMattPro marked this pull request as draft October 27, 2026 13:56
@iMattPro iMattPro added the WIP label Oct 27, 2026
@codecov-commenter

codecov-commenter commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.99244% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.82%. Comparing base (14f834f) to head (3f062a7).

Files with missing lines Patch % Lines
controller/acp_controller.php 98.44% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #174      +/-   ##
============================================
- Coverage     99.02%   98.82%   -0.20%     
- Complexity      125      225     +100     
============================================
  Files             9        9              
  Lines           410      682     +272     
============================================
+ Hits            406      674     +268     
- Misses            4        8       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants