Repository navigation
Regenerate the analyzer baseline under Mago 1.56.1 - #229
Merged
Merged
Conversation
CI installs the latest Mago, and 1.56.1 reports fifteen findings the 1.52.0 baseline does not cover: null and mixed access in the two gateways, a nullable result passed to ResultSetInterface::initialize(), an imprecise array in TableGatewayEvent, and a PDOStatement passed where DriverInterface::createResult() documents a resource. The same run drops 89 entries for issues that no longer exist, left by the Sql and ResultSet work. The baseline falls from 795 issues to 721.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Oct 11, 2026
simon-mundy
marked this pull request as draft
October 11, 2026 23:09
simon-mundy
marked this pull request as ready for review
October 11, 2026 23:34
simon-mundy
added
enhancement
tyrsson
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI installs the latest Mago through
setup-php(tools: mago). The last green run on0.6.xused 1.54.0. Under 1.56.1,mago analyzefails on0.6.xwith fifteen findings the baseline does not cover. This PR regenerates the analyzer baseline so the upcoming Sql compliance branches start from a green base. No source files change.Result
mago format --check,mago lint,mago analyzeandmago guardare clean under 1.56.1 for PHP 8.3, 8.4 and 8.5.Newly reported, now baselined
AbstractRowGateway: possible method access onnull(5)AbstractTableGateway:mixedarguments toUpdate::join()(3), possible method access onnull(3), and a nullableResultInterfacepassed toResultSetInterface::initialize()(2)TableGatewayEvent::getParams(): imprecisearrayreturn type (1)AbstractPdoConnection: passes aPDOStatementtoDriverInterface::createResult(), whose parameter is documented asresource(1)The last one is a real docblock mismatch rather than analyzer noise. It is left for the Adapter/Driver pass.
Dropped
89 entries for issues that no longer exist, left by the recent Sql and ResultSet work.