Repository navigation
feat: upgrade to Angular 22 - #53
Merged
Merged
Conversation
getCurrentTextSelection() counted all text rendered before the selection, including text added by custom annotation renderers (e.g. labels), and counted Unicode code points while annotation indices use UTF-16 code units. Both produced wrong offsets: with custom renderers and in texts containing emojis.
philenius
force-pushed
the
feat/upgrade-to-angular-22
branch
from
October 30, 2026 00:15
29f0fe9 to
05ce0be
Compare
…nt OnPush getCurrentTextSelection() threw a WrongDocumentError when the component is inside a shadow root and the selection is outside of it. It now returns undefined. Document in the README and CHANGELOG that annotations must be updated by assigning a new array, since OnPush doesn't detect in-place changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #52