Repository navigation
Conversation
…error handling Update crates-index dependency version to 3.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2396, where
cargo pgrx upgradewithout--tofails withNo such file or directoryon Cargo 1.85 and newer. Since 0.19.0 (#2305) the latest version comes from Cargo's local index cache, butcrates-indexstill defaults to the cache directory name Cargo used before 1.85, so the lookup reads a directory that does not exist. The command now opens the current directory withSparseIndex::from_url_with_hash_kindandHashKind::Stable, and only the discover modes carry the index, so--tonever reads the cache. A missingCargo.tomlnow reports the path and--manifest-pathinstead of a bareNo such file or directory.The pre-1.85 cache directory is deliberately no longer read, because falling back to it could silently report an outdated latest version. Cargo 1.85 and newer no longer update that directory, and pgrx 0.17 and later use edition 2024 (Rust 1.85 or newer) with 0.19 requiring Rust 1.96, so projects on those versions already use the new one. Only someone upgrading from pgrx 0.16 or older with a Cargo older than 1.85 is affected, and for them
--tostill works.Found while testing: with a path-only
pgrxdependency, discover mode still needs a cache entry because the lookup runs before the version check;unimplemented!("custom registry")panics on user input; and the tracing span onupdate_manifestprints the whole manifest in error output.