Repository navigation
Conversation
GucSetting is Sync and get() had no doc comment, so nothing warned that reading a GUC from a thread a background worker spawned panics in check_active_thread. Closes pgcentralfoundation#2366.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GucSetting::get()callscheck_active_thread()and so panics when called from any thread other than the active Postgres thread, but it had no doc comment, andGucSettingisSync. Background workers that re-read a GUC from a spawned thread hit this only at runtime. This adds a# Panicssection saying so and suggests reading the value on the active thread and passing it along. Closes #2366.