Repository navigation
Conversation
- Delete HelpSupportTile.js component that showed 'Was this page helpful?' Yes/No buttons and support links at the bottom of certain pages - Remove imports and usages from 5 embeddable-uis section pages: - overview.mdx - permission-levels.mdx - email-configuration-and-templates.mdx - user-preview.mdx - webhooks.mdx The widget had non-functional buttons (setEmail/textBox not defined) and was not collecting feedback. Removed per request from CEO Or. Co-authored-by: Or Weis <orweis@users.noreply.github.com>
✅ Deploy Preview for permitio-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the "Was this page helpful?" feedback widget from the Permit Elements documentation section, per request from CEO Or.
What changed
Deleted component:
src/components/elements/HelpSupportTile.js- The widget showing "Was this page helpful?" Yes/No buttons, support links, and an email signup formUpdated pages (removed import and usage):
docs/embeddable-uis/overview.mdxdocs/embeddable-uis/permission-levels.mdxdocs/embeddable-uis/email-configuration-and-templates.mdxdocs/embeddable-uis/user-preview.mdxdocs/embeddable-uis/webhooks.mdxReason
The widget was not being used and the buttons were non-functional (referenced undefined
setEmailandtextBoxfunctions). No feedback was being collected from users.Testing