Repository navigation
Core models blogpost review - #2345
Open
clementblaudeau wants to merge 9 commits into
Open
clementblaudeau wants to merge 9 commits into
clementblaudeau wants to merge 9 commits into
Conversation
clementblaudeau
added
the
documentation
maximebuyse
reviewed
Oct 26, 2026
maximebuyse
left a comment
maximebuyse
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the corrections and additional context. I added some suggestions and corrections.
Comment on lines
+30
to
+31
| below), can be extracted to various backends, factoring out the modeling effort, | ||
| and can be reviewed at the rust level, improving the overall confidence. |
Contributor
There was a problem hiding this comment.
Too many commas in this sentence
| --- | ||
|
|
||
| The obvious factor that limits Rust code that can be analyzed using hax is the set of features supported by the translation. But extracted code relies on the Rust standard library, which needs a model in our proof backends and this also limits what code can be analyzed with hax. | ||
| Verification does not happens in a vacuum, but as part of a stack: verifying a |
Contributor
There was a problem hiding this comment.
This looks a bit like the caricatural AI sentence ("It's not A it's B")
Contributor
Author
There was a problem hiding this comment.
Indeed, although I guarantee it's human written!
Co-authored-by: maximebuyse <45398004+maximebuyse@users.noreply.github.com>
Co-authored-by: maximebuyse <45398004+maximebuyse@users.noreply.github.com>
Co-authored-by: maximebuyse <45398004+maximebuyse@users.noreply.github.com>
Co-authored-by: maximebuyse <45398004+maximebuyse@users.noreply.github.com>
Co-authored-by: maximebuyse <45398004+maximebuyse@users.noreply.github.com>
Co-authored-by: maximebuyse <45398004+maximebuyse@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.