Repository navigation
fix(engine): keep hoisted bindings from capturing variables - #2342
Draft
maximebuyse wants to merge 1 commit into
Draft
maximebuyse wants to merge 1 commit into
maximebuyse wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2338.
Fixes #1734.
Simplify_hoistingno longer inlines a hoisted expression under a rebinding of one of its variables. For instance,add(bump(a), set(b))was extracted asadd out out, andadd(v, { v = 5; 1 })read the newv.lets that would shadow another variable are renamed (x_1). Bindings get unique ids from Rust's name-based scoping before hoisting, captures are detected after hoisting, and the original ids are restored. Ids are rebuilt because the Rust engine round trip keeps only the names of local identifiers.evaluation_orderandissue_1734modules in thehoistingtest crate.side-effectssnapshot changes:add3(x, { x = x + 1; .. }, x)now passes the oldxas first argument, as in Rust.